Re: [PATCH] gpiolib: of: add polarity quirk for TSC2005

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Wed, Jul 3, 2024 at 8:26 PM Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:


> DTS for Nokia N900 incorrectly specifies "active high" polarity for
> the reset line, while the chip documentation actually specifies it as
> "active low".  In the past the driver fudged gpiod API and inverted
> the logic internally, but it was changed in d0d89493bff8.
>
> Fixes: d0d89493bff8 ("Input: tsc2004/5 - switch to using generic device properties")
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>

Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

> OTOH if this was indeed broken, then it was broken for ~7 years
> (d0d89493bff8 went in 4.11-rc1), so maybe the best way is not to worry
> about compatibility with old DTS, update
> arch/arm/boot/dts/ti/omap/omap3-n900.dts in the tree and call it a day.

I think anybody using the n900 wll be updating DTS and kernel in tandem
so yeah. But I think it's nice that we do both since you anyway made
the patch, it doesn't hurt.

Yours,
Linus Walleij