Re: [PATCH] gpio: mcp23s08: support setting pullups from device tree data

[Alexander Stein <alexander.stein@xxxxxxxxxxxxxxxxxxxxx>]

On Friday 04 December 2015 13:46:13, Timo Teräs wrote:
> Make pullup configurable from device tree data.
> 
> Signed-off-by: Timo Teräs <timo.teras@xxxxxx>
> ---
> I'm not fully certain how the pullup data should be made configurable via OF.
> gpio-twl4030.c uses similar approach as this, but gpio-samsung.c makes the
> pullup configuration seems to be part of the custom data in gpio specifiers.

I think this should be specified for each individual GPIO. e.g.
> gpios = <&gpio-ctrl 0 GPIO_ACTIVE_HIGH GPIO_PULLUP>;

You don't know (yet) which pins might need a internal pull-up when specifying the mcp23s08 node itself.
You might override the controller node in your dts, but so you need to adjust 2 entries, one for the user and one for the pullup, rather than have all options at one place.

Best regards,
Alexander
-- 
Dipl.-Inf. Alexander Stein
SYS TEC electronic GmbH
alexander.stein@xxxxxxxxxxxxxxxxxxxxx

Legal and Commercial Address:
Am Windrad 2
08468 Heinsdorfergrund
Germany

Office: +49 (0) 3765 38600-0
Fax:    +49 (0) 3765 38600-4100
 
Managing Directors:
	Director Technology/CEO: Dipl.-Phys. Siegmar Schmidt;
	Director Commercial Affairs/COO: Dipl. Ing. (FH) Armin von Collrepp
Commercial Registry:
	Amtsgericht Chemnitz, HRB 28082; USt.-Id Nr. DE150534010

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html