On 2024-06-25 14:16 UTC, Jonas Gorski wrote: > >> - /* Use base 0 to stay compatible with legacy platforms */ >> - ctrl->gc.base = 0; >> + /* Dynamic allocation */ >> + ctrl->gc.base = -1; > >bgpip_init() will already have set gc.base to -1, so you can just drop >the assignment. > >Best Regards, >Jonas > Thanks, I've updated it in v2 patch: https://lore.kernel.org/linux-gpio/TYCP286MB089598EA71E964BD8AB9EFD3BCD62@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ Regards, Shiji Yang