Re: [PATCH] dt-bindings: pinctrl: pinctrl-single: Define a max count for "pinctrl-single,gpio-range"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11:19-20240619, Andrew Davis wrote:
[...]

> 
> This binding is a bit of a mess, the phandle is always a pointer to
> a node with the cells length hard-coded to 3. This looks to have been done
> to allow the driver to use the function "of_parse_phandle_with_args" which
> needs a property name for to find the cell count. But that makes no sense
> as the count is always 3, the driver cannot accept any other value. The
> driver should have just looped of_get_property() 3 times but wanted to
> use the helper. So a silly driver mistake has turned into a binding issue.
> 
> We should drop the "pinctrl-single,gpio-range" from the binding and
> fix the driver.

Linus W: pinctrl-single,gpio-range -> any thoughts here? I think it is a
valid (if a bit too flexible design looking at the existing users who
just use a single mux value mapping for all modes)

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D




[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux