Re: [libgpiod][PATCH v2] bindings: python: add script to generate sdist and wheels

[Bartosz Golaszewski <brgl@xxxxxxxx>]

On Thu, Jun 6, 2024 at 8:13 PM Vincent Fazio <vfazio@xxxxxxxxx> wrote:
>
> Introduce a shell script that generates an sdist tarball and PEP 600/656
> conformant wheels.
>
> The wheels are generated via cibuildwheel, a tool provided by the Python
> Packaging Authority (PyPA) [0]. The tool leverages toolchains within
> containers maintained by PyPA [1] to generate wheels that are runnable
> on hosts that meet the platform compatibility tag [2] requirements.
>
> By default, the script creates X86_64 and AArch64 CPython 3.9-3.12
> wheels for glibc and musl libc based systems.
>
> These defaults can be overridden via CIBW_* environment variables [3].
>
> [0]: https://cibuildwheel.pypa.io/en/stable/
> [1]: https://github.com/pypa/manylinux/
> [2]: https://packaging.python.org/en/latest/specifications/platform-compatibility-tags/
> [3]: https://cibuildwheel.pypa.io/en/stable/options/#options-summary
>
> Signed-off-by: Vincent Fazio <vfazio@xxxxxxxxx>
> ---
> Changes v1 -> v2:
>  - spaces -> tabs
>  - conform to `shellcheck -oall` recommendations
>  - simplify in-script documentation
>  - miscellaneous grammar fixups
> ---
>  bindings/python/generate_pypi_artifacts.sh | 132 +++++++++++++++++++++
>  1 file changed, 132 insertions(+)
>  create mode 100755 bindings/python/generate_pypi_artifacts.sh
>
> diff --git a/bindings/python/generate_pypi_artifacts.sh b/bindings/python/generate_pypi_artifacts.sh
> new file mode 100755
> index 0000000..5e526be
> --- /dev/null
> +++ b/bindings/python/generate_pypi_artifacts.sh
> @@ -0,0 +1,132 @@
> +#!/usr/bin/env sh
> +#
> +# This is a script to generate an sdist and wheels for publishing to PyPI.
> +#

One more nit: can you add SPDX headers for the license and copyright,
so that it passes the `reuse lint` check?

Bart