On Tue, Jun 4, 2024 at 10:28 AM Florian Fainelli <florian.fainelli@xxxxxxxxxxxx> wrote: > On 6/3/2024 8:19 PM, Stefan Wahren wrote: ... > LGTM but sometimes I really wonder to what degree should we invent a > helper function... The rationale for the messaging is unification, that's why helpers like dev_err_probe() (for known non-deferred error codes), str_*() choices, and %pt (to have time and date be printed) are good to have. In general I agree that we should't become fanatics of hiding everything behind the macros and helpers. -- With Best Regards, Andy Shevchenko
Re: [PATCH 2/2] pinctrl: bcm2835: Use string_choices API instead of ternary operator
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH 2/2] pinctrl: bcm2835: Use string_choices API instead of ternary operator
- From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
- Date: Tue, 4 Jun 2024 10:33:18 +0300
- In-reply-to: <7ccb2786-0c04-4058-9ea2-e611deebf1ef@broadcom.com>
- References: <20240603181938.76047-1-wahrenst@gmx.net> <20240603181938.76047-3-wahrenst@gmx.net> <7ccb2786-0c04-4058-9ea2-e611deebf1ef@broadcom.com>
- References:
- [PATCH 0/2] pinctrl: bcm2835: persist_gpio_outputs follow-up
- From: Stefan Wahren
- [PATCH 2/2] pinctrl: bcm2835: Use string_choices API instead of ternary operator
- From: Stefan Wahren
- Re: [PATCH 2/2] pinctrl: bcm2835: Use string_choices API instead of ternary operator
- From: Florian Fainelli
- [PATCH 0/2] pinctrl: bcm2835: persist_gpio_outputs follow-up
- Prev by Date: Re: [PATCH 2/2] pinctrl: bcm2835: Use string_choices API instead of ternary operator
- Next by Date: Re: [PATCH v6 1/2] dt-bindings: pwm: Add pwm-gpio
- Previous by thread: Re: [PATCH 2/2] pinctrl: bcm2835: Use string_choices API instead of ternary operator
- Next by thread: [PATCH 1/2] pinctrl: bcm2835: Fix permissions of persist_gpio_outputs
- Index(es):
 |