Re: [PATCH v2 2/2] pinctrl: rockchip: add rk3308b SoC support

[Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>]

Hello Dmitry,

On Wed, 29 May 2024 19:35:34 +0500
Dmitry Yashin <dmt.yashin@xxxxxxxxx> wrote:

> Add pinctrl support for rk3308b. This pin controller much the same as
> rk3308's, but with additional iomux routes and 3bit iomuxes selected
> via gpio##_sel_src_ctrl registers. Set them up in the function
> rk3308b_soc_sel_src_init to use new 3bit iomuxes over some 2bit old
> ones and update iomux_recalced and iomux_routes for the new SoC's.
> 
> Fixes: 1f3e25a06883 ("pinctrl: rockchip: fix RK3308 pinmux bits")
> Signed-off-by: Dmitry Yashin <dmt.yashin@xxxxxxxxx>

Thank you for adding runtime chip ID detection!

Reviewed-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com