On Mon, 3 Jun 2024 at 14:24, Kent Gibson <warthog618@xxxxxxxxx> wrote: > > On Mon, Jun 03, 2024 at 11:34:15AM +0200, Bartosz Golaszewski wrote: > > On Fri, May 31, 2024 at 8:42 PM Khem Raj <raj.khem@xxxxxxxxx> wrote: > > > > > > Catch2 v3.x has API changes which needs to be addressed > > > in the tests themselves, hence this changeset is to fix > > > those. > > > > > > Signed-off-by: Khem Raj <raj.khem@xxxxxxxxx> > > > Cc: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > > > --- > > > > Thanks for doing this, I recently added it to my TODO. I slightly > > modified the change - added a version requirement for catch2 to > > configure.ac (>= 3.0). > > > > The only issue I have with the patch is that Debian stable, and all the > distros based on it, are still on v2, so building for them will now > require backporting catch2 from Debian testing. > Probably not a deal-breaker, but another hurdle to be jumped. > > Cheers, > Kent. That's alright. It's been 4 years since the release of catch2 v3.0. Bart