Re: [libgpiod][PATCH v2 0/8] tools: tests: fix shellcheck warnings

[Bartosz Golaszewski <brgl@xxxxxxxx>]

From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>


On Mon, 03 Jun 2024 19:56:20 +0800, Kent Gibson wrote:
> Following up on recent discussions, this series fixes all the warnings
> detected by shellcheck.  The resulting tools test script is now clean,
> at least from the perspective of shellcheck.
> 
> These fixes do not correct any known issue, other than shellcheck
> reporting them as potential problems, the intent is to remove common
> shell issues that may impact future changes, and to simplify checking
> that any subsequent changes to the test script constitute "good" shell.
> 
> [...]

Applied, thanks!

[1/8] tools: tests: don't mix string and array
      commit: ee9751a07dee230229e4b85dde14c600397e026d
[2/8] tools: tests: declare and assign separately
      commit: 57ed5cfe66f03d0a30f34aa319560e9079bbcee3
[3/8] tools: tests: fix unused variables
      commit: a88ed2f9bfbf3b73c156f8db45b6b6af62291c53
[4/8] tools: tests: use read -r to avoid mangling backslashes
      commit: 48f634ab57e8b2c0173a4138737895bee070c493
[5/8] tools: tests: don't use variables in printf format string
      commit: 45f2d4ba38852b611bc4bf622b2582de85b0ab91
[6/8] tools: tests: check exit code directly
      commit: 934adda1339707f4721af0a7a128e20737ed9986
[7/8] tools: tests: shellcheck don't follow sourced file
      commit: 2f140aed7d3cebb3dd67a31f8fd6846f3c5a480d
[8/8] tools: tests: avoid splitting and globbing
      commit: 37f3676cef721e6909ea84cd6c4ada5dab84f4fb

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>