Re: [libgpiod][PATCH 2/8] tools: tests: don't declare and assign separately

[Kent Gibson <warthog618@xxxxxxxxx>]

On Mon, Jun 03, 2024 at 12:38:09PM +0200, Bartosz Golaszewski wrote:
> On Mon, Jun 3, 2024 at 10:58 AM Kent Gibson <warthog618@xxxxxxxxx> wrote:
> >
> > On Mon, Jun 03, 2024 at 10:52:39AM +0200, Bartosz Golaszewski wrote:
> > > On Fri, May 31, 2024 at 3:45 PM Kent Gibson <warthog618@xxxxxxxxx> wrote:
> > > >
> > > > Fix shellcheck SC2155[1] - declare and assign separately to avoid
> > > > masking return values.
> > > >
> > > > Signed-off-by: Kent Gibson <warthog618@xxxxxxxxx>
> > > >
> > > > [1] https://www.shellcheck.net/wiki/SC2155
> > > > ---
> > >
> > > Shouldn't the commit message say "*do* declare and assign separately"?
> > >
> >
> > That is wrong, my bad.
> >
> > I think I was going to change it to "don't declare and assign together"
> > and got distracted mid-edit.
> > So either that or simply "declare and assign separately".
> > A leading "do" would be redundant.
> >
> > You ok to fix that, or would you like a re-spin?
> >
>
> I'll fix it, others look good.
>

Thanks.

Kent.