Re: [PATCH 1/9] pinctrl: renesas: rzg2l: Fix variable names in OEN functions

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Paul,

On Fri, May 24, 2024 at 11:46 AM Paul Barker
<paul.barker.ct@xxxxxxxxxxxxxx> wrote:
> The variable naming in the various OEN functions has been confusing. We
> were passing the _pin variable from rzg2l_pinctrl_pinconf_get() and
> rzg2l_pinctrl_pinconf_set() as the offset argument to rzg2l_read_oen()
> and rzg2l_write_oen(), when this is not a register offset.
>
> What we actually need here is the port index, so that we can compare
> this to oen_max_port.
>
> We can also clean up rzg2l_pin_to_oen_bit(), removing an unnecessary
> branch and clarifying the variable naming.
>
> Signed-off-by: Paul Barker <paul.barker.ct@xxxxxxxxxxxxxx>

I think this makes sense.
It will impact Prabhakar's RZ/V2H series, which demultiplexes
these for RZ/V2H vs. RZ/G2L (G3S).

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds