Re: [PATCH] pinctrl: renesas: rzn1: Use for_each_child_of_node_scoped()

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Andy,

On Thu, May 30, 2024 at 11:26 AM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> Thu, May 30, 2024 at 11:19:29AM +0200, Geert Uytterhoeven kirjoitti:
> > Use the scoped variant of for_each_child_of_node() to simplify the code.
>
> I do not see the point of this patch. This makes code actually more
> complicated, and I'm not sure the code generation is the same and not worse.

On arm32, a conversion to for_each_child_of_node_scoped() seems to
cost ca. 48 bytes of additional code.

BTW, the same is true for cases where the conversion does simplify
cleanup.

I checked "pinctrl: renesas: Use scope based of_node_put() cleanups",
and all but the conversions in *_dt_node_to_map() cost 48 bytes each.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds