Re: [PATCH v2 03/14] mfd: pm8008: deassert reset on probe

[Johan Hovold <johan@xxxxxxxxxx>]

On Wed, May 29, 2024 at 10:45:40PM +0300, Andy Shevchenko wrote:
> On Wed, May 29, 2024 at 7:30 PM Johan Hovold <johan+linaro@xxxxxxxxxx> wrote:
> >
> > Request and deassert any (optional) reset gpio during probe in case it
> > has been left asserted by the boot firmware.
> >
> > Note the reset line is not asserted to avoid reverting to the default
> > I2C address in case the firmware has configured an alternate address.
> 
> ...
> 
> > +       /*
> > +        * The PMIC does not appear to require a post-reset delay, but wait
> > +        * for a millisecond for now anyway.
> > +        */
> 
> > +       usleep_range(1000, 2000);
> 
> fsleep() ?

No, I'd only use fsleep() when the argument is variable.

Johan