Re: [PATCH v2] gpio: Add IRQ support to ACCES 104-IDIO-16 driver

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Tue, Nov 3, 2015 at 1:54 PM, William Breathitt Gray
<vilhelm.gray@xxxxxxxxx> wrote:

> The ACCES 104-IDIO-16 series offers Change-of-State detection interrupt
> functionality; if Change-of-State detection is enabled, an interrupt is
> fired off if any input line changes state (i.e. goes from low to high,
> or from high to low). This patch adds support to handle these interrupts
> and allows the user to mask which GPIO lines are affected. The interrupt
> line number for the device may be set via the idio_16_irq module
> parameter.
>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@xxxxxxxxx>
> ---
> Changes in v2:
>   - Remove includes for <linux/irq.h> and <linux/irqdomain.h>
>   - Rename uppercase variable names to lowercase
>   - Utilize the BIT macro
>   - Move IRQ acknowledgement code to irq_ack callback
>   - Use handle_edge_irq since this device only handles edge IRQs

Looks just good.

Patch applied for v4.5.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html