On Wed, Nov 4, 2015 at 9:30 PM, William Breathitt Gray <vilhelm.gray@xxxxxxxxx> wrote: > To prevent confusion and to match existing coding style used in other > gpio drivers symbol names within the 104-idio-16 gpio driver should be > lowercase. ... and for the same styling reasons "GPIO" should be spelled in uppercase in your commit message. ;) Apart from that this patch seems harmless and the repositioning of some constant declarations is also welcome. Reviewed-by: Alexandre Courbot <acourbot@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html