Re: [PATCH v2 5/6] regulator: tps65086: Add regulator driver for the TPS65086 PMIC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 30, 2015 at 05:41:43PM -0500, Andrew F. Davis wrote:

> +struct tps65086_regulator {
> +	struct regulator_desc desc;
> +	unsigned int decay_reg;
> +	unsigned int decay_mask;

The decay_reg and decay_mask fields appear to be entirely write only,
why are they present?

> +	ret = of_regulator_match(&pdev->dev, pdev->dev.of_node,
> +				 tps65086_matches,
> +				 ARRAY_SIZE(tps65086_matches));
> +	if (ret < 0) {
> +		dev_err(tps->dev, "Error parsing regulator init data\n");
> +		return ret;
> +	}

Please match regulators using the fields in the regulator_desc rather
than open coding.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux