RE: the needless loop?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Linus, Andriy,

> On Wed, Oct 21, 2015 at 6:45 PM, Shevchenko, Andriy
> <andriy.shevchenko@xxxxxxxxx> wrote:
> 
> > Catch such code in pinconf.c
> >
> >          for (j = 0; j < map->data.configs.num_configs; j++) {
> >                  if (!strcmp(map->data.configs.group_or_pin,
> >                                  dbg->pin_name)) {
> >                          /* We found the right pin / state */
> >                          found = map;
> >                          break;
> >                  }
> >          }
> >
> > I do not get how the result of strcmp() would be different during the
> > loop. Can you elaborate?
>
> As you can see from git blame Laurent Meunier wrote this code, (commit
> f07512e615dd8) so let's ask him. I suspect a simple copy/paste error?
> Laurent?

Indeed obviously a copy / paste error I did 
The loop shall be removed ... Has someone already any plan to send the fix ? 

Laurent

> Yours,
> Linus Walleij
��.n��������+%������w��{.n�����{��
b���ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f




[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux