On Tue, Oct 27, 2015 at 11:06:58AM +0100, Linus Walleij wrote: > On Mon, Oct 19, 2015 at 6:59 PM, William Breathitt Gray > <vilhelm.gray@xxxxxxxxx> wrote: > > > The ACCES 104-IDIO-16 family of PC/104 utility boards feature 16 > > optically isolated inputs and 16 optically isolated FET solid state > > outputs. This driver provides GPIO support for these 32 channels of > > digital I/O. Change-of-State detection interrupts are not supported. > > > > GPIO 0-15 correspond to digital outputs 0-15, while GPIO 16-31 > > correspond to digital inputs 0-15. The base port address for the device > > may be set via the idio_16_base module parameter. > > > > Signed-off-by: William Breathitt Gray <vilhelm.gray@xxxxxxxxx> > > --- > > Changes in v10: > > - Rename symbols to be more concise > > - Allocate GPIO device private data structure in probe function > > Yes, exactly like this. :) > > Patcha applied for kernel v4.4. > > > +menu "ISA GPIO drivers" > > + > > +config GPIO_104_IDIO_16 > > + tristate "ACCES 104-IDIO-16 GPIO support" > > + depends on X86 > > + help > > + Enables GPIO support for the ACCES 104-IDIO-16 family. > > + > > +endmenu > > I have five other drivers using port-based I/O: > > gpio-f7188x.c > gpio-it87.c > gpio-sch.c > gpio-sch311x.c > gpio-ts5500.c > > Do you think it makes sense to move all of these in under > the "ISA GPIO drivers" menu as well? I guess they all require > ISA after all. > > (Added their maintainers to the To: line so I can get some input > on this.) Hi Linus, The Super-I/Os are connected to a LPC bridge. And since LPC is much like ISA for software, then I guess it makes sense to move the drivers gpio-f7188x and gpio-it87 under a "ISA GPIO drivers" menu. Simon
Attachment:
signature.asc
Description: Digital signature