Re:[PATCH v3] gpio: driver for AMD Promontory

[YD Tseng <ltyu101@xxxxxxxxx>]

> > Dear all:
> >
> > This patch adds a new GPIO driver for AMD Promontory chip.  This GPIO controller is enumerated by ACPI and the ACPI compliant hardware ID is AMDF030.
> >
> > Signed-off-by: YD Tseng <Yd_Tseng@xxxxxxxxxxxxxx>
>
> Please fix subject line to
> "gpio: driver for AMD Promontory"
>
> Put a line-wrapped concise description in the driver commit blurb.
>

fixed in the new submission.

> > +#define TOTAL_GPIO_PINS 8
>
> Call this PT_TOTAL_GPIO 8 or so.
>

fixed in the new patch.

> > +config GPIO_AMDPT
> > +       tristate "AMD Promontory GPIO support"
> > +       depends on PCI && ACPI
>
> Why does this depend on PCI when it's an ACPI platform device?
>

removed PCI dependency in Kconfig.

> Yours,
> Linus Walleij

Best Regards,
YD Tseng
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html