Re: [PATCH v3] drivers: field for new GPIO driver

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Wed, Oct 14, 2015 at 12:16 PM, YD Tseng <ltyu101@xxxxxxxxx> wrote:

> Dear all:
>
> This patch adds a new GPIO driver for AMD Promontory chip.  This GPIO controller is enumerated by ACPI and the ACPI compliant hardware ID is AMDF030.
>
> Signed-off-by: YD Tseng <Yd_Tseng@xxxxxxxxxxxxxx>

Please fix subject line to
"gpio: driver for AMD Promontory"

Put a line-wrapped concise description in the driver commit
blurb.

> +#define TOTAL_GPIO_PINS 8

Call this PT_TOTAL_GPIO 8 or so.

> +config GPIO_AMDPT
> +       tristate "AMD Promontory GPIO support"
> +       depends on PCI && ACPI

Why does this depend on PCI when it's an ACPI platform device?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html