RE: [PATCH] pinctrl: always include all subdirectories in build

[<yamada.masahiro@xxxxxxxxxxxxx>]

Hi.


> From: linux-gpio-owner@xxxxxxxxxxxxxxx
> [mailto:linux-gpio-owner@xxxxxxxxxxxxxxx] On Behalf Of Jonas Gorski
> Sent: Monday, October 12, 2015 12:41 AM
> To: linux-gpio@xxxxxxxxxxxxxxx
> Cc: Linus Walleij; Alexandre Courbot; Thomas Petazzoni; Stephen Warren;
> Lee Jones; Eric Anholt; Florian Fainelli; Ray Jui; Scott Branden; Mika
> Westerberg; Heikki Krogerus; Matthias Brugger; Maxime Coquelin; Kumar Gala;
> Andy Gross; David Brown; Viresh Kumar; Tomasz Figa; Tony Prisk; Sebastian
> Hesselbarth; Laurent Pinchart; Yamada, Masahiro/山田 真弘
> Subject: [PATCH] pinctrl: always include all subdirectories in build
> 
> All pinctrl drivers in subdirectories are properly guarded by individual
> configuration symbols, so there is no need to limit the directories to the
> belonging machines.
> 
> This allows wider COMPILE_TEST coverage on "foreign" targets.
> 
> Signed-off-by: Jonas Gorski <jogo@xxxxxxxxxxx>
> ---
>  drivers/pinctrl/Makefile | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile index
> cad077c..2eb25a8 100644
> --- a/drivers/pinctrl/Makefile
> +++ b/drivers/pinctrl/Makefile
> @@ -39,17 +39,17 @@ obj-$(CONFIG_PINCTRL_TB10X)	+= pinctrl-tb10x.o
>  obj-$(CONFIG_PINCTRL_ST) 	+= pinctrl-st.o
>  obj-$(CONFIG_PINCTRL_ZYNQ)	+= pinctrl-zynq.o
> 
> -obj-$(CONFIG_ARCH_BCM)		+= bcm/
> -obj-$(CONFIG_ARCH_BERLIN)	+= berlin/
> +obj-y				+= bcm/
> +obj-y				+= berlin/
>  obj-y				+= freescale/
> -obj-$(CONFIG_X86)		+= intel/
> -obj-$(CONFIG_PLAT_ORION)        += mvebu/
> +obj-y				+= intel/
> +obj-y				+= mvebu/
>  obj-y				+= nomadik/
> -obj-$(CONFIG_ARCH_QCOM)		+= qcom/
> -obj-$(CONFIG_PINCTRL_SAMSUNG)	+= samsung/
> -obj-$(CONFIG_PINCTRL_SH_PFC)	+= sh-pfc/
> -obj-$(CONFIG_PLAT_SPEAR)	+= spear/
> -obj-$(CONFIG_ARCH_SUNXI)	+= sunxi/
> -obj-$(CONFIG_ARCH_UNIPHIER)	+= uniphier/
> -obj-$(CONFIG_ARCH_VT8500)	+= vt8500/
> -obj-$(CONFIG_ARCH_MEDIATEK)	+= mediatek/
> +obj-y				+= qcom/
> +obj-y				+= samsung/
> +obj-y				+= sh-pfc/
> +obj-y				+= spear/
> +obj-y				+= sunxi/
> +obj-y				+= uniphier/
> +obj-y				+= vt8500/
> +obj-y				+= mediatek/


Currently, I only see COMPILE_TEST under  bcm/, mediatek/, and qcom/.
For the others, Kbuild would descend into unneeded subdirectories
just for creating empty built-in.o objects.

Moreover, samsung/ and sh-pfc/ are already enabled by CONFIG_PINCTRL_*.
No need to change these two at least.

Best Regards
Masahiro Yamada

ÿ抅º{.nÇ+‰·Ÿ®‰­†+%ŠËÿ演欟¥Šwÿº{.nÇ+‰轡Š{応
bｘФ›＋¨}©ž夏 zÚ&j:+v‰?ø媧®w?Šà2ŠÞ™◑?&¢)漾«a筋ÿÿ䗪z推z閤—ú+ƒùšŽŠ蘗jÿŠw蕈f