Re: [PATCH v4 2/6] pinctrl: berlin: add the berlin4ct pinctrl driver

[Antoine Tenart <antoine.tenart@xxxxxxxxxxxxxxxxxx>]

Hi Jisheng,

On Fri, Oct 09, 2015 at 04:17:05PM +0800, Jisheng Zhang wrote:
> diff --git a/drivers/pinctrl/berlin/Kconfig b/drivers/pinctrl/berlin/Kconfig
> index b18322b..c13f6d2 100644
> --- a/drivers/pinctrl/berlin/Kconfig
> +++ b/drivers/pinctrl/berlin/Kconfig
> @@ -17,4 +17,9 @@ config PINCTRL_BERLIN_BG2Q
>  	bool
>  	select PINCTRL_BERLIN
>  
> +config PINCTRL_BERLIN_BG4CT
> +	depends on OF && (ARCH_BERLIN || COMPILE_TEST)
> +	bool "Marvell berlin4ct pin controller driver"
> +	select PINCTRL_BERLIN
> +
>  endif

This endif ends the following condition:

	if ARCH_BERLIN
	[...]

So the "depends on ARCH_BERLIN" here can be dropped. Also the
COMPILE_TEST can be moved as it isn't BG4CT specific and all other
Berlin pinctrl drivers would benefit from this.

So we would have something like:

	if (ARCH_BERLIN || COMPILE_TEST)
	[...]
	endif

Finally you can move the OF dependency to the PINCTRL_BERLIN config as
all Berlin pinctrl drivers depends on it.

Thanks!

Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html