Re: [PATCH] gpio: keep the GPIO line names internal

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Oct 4, 2015 at 3:37 PM, Johan Hovold <johan@xxxxxxxxxx> wrote:

> This looks good (apart from the checkpatch warning for the warning
> message string).

Yeah the GPIO maintainer is liberal about that rule...

> You also need to revert ddd5404007b8 ("gpio-sysfs: Use gpio descriptor
> name instead of gpiochip names array") however as this is an ABI change.
> Otherwise pins with a name in DT will now be exported using the gpio name
> rather than number as they used to be. [ The current behaviour is
> maintained by exporting names from chip->names for hard coded names
> only. ]

I think it is ABI-correct: it uses desc->name if that is set, and
currently that is only set from chip->names[] so status quo.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux