Re: [PATCH v2] pinctrl: imx25: ensure that a pin with id i is at position i in the info array

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Wed, Sep 23, 2015 at 7:35 AM, Uwe Kleine-König
<u.kleine-koenig@xxxxxxxxxxxxxx> wrote:

> The code in pinctrl-imx.c only works correctly if in the
> imx_pinctrl_soc_info passed to imx_pinctrl_probe we have:
>
>         info->pins[i].number = i
>         conf_reg(info->pins[i]) = 4 * i
>
> (which conf_reg(pin) being the offset of the pin's configuration
> register).
>
> When the imx25 specific part was introduced in b4a87c9b966f ("pinctrl:
> pinctrl-imx: add imx25 pinctrl driver") we had:
>
>         info->pins[i].number = i + 1
>         conf_reg(info->pins[i]) = 4 * i
>
> . Commit 34027ca2bbc6 ("pinctrl: imx25: fix numbering for pins") tried
> to fix that but made the situation:
>
>         info->pins[i-1].number = i
>         conf_reg(info->pins[i-1]) = 4 * i
>
> which is hardly better but fixed the error seen back then.
>
> So insert another reserved entry in the array to finally yield:
>
>         info->pins[i].number = i
>         conf_reg(info->pins[i]) = 4 * i
>
> Fixes: 34027ca2bbc6 ("pinctrl: imx25: fix numbering for pins")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
> Changes since (implicit) v1 sent with Message-Id:
> 1443018584-12186-1-git-send-email-u.kleine-koenig@xxxxxxxxxxxxxx :

Patch applied for fixes.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html