Re: [PATCH 1/9] sh-pfc: modify PINMUX_IPSR_MSEL() macro order

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Wed, Sep 2, 2015 at 12:44 AM, Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:

> From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
>
> The difference between PINMUX_IPSR_MSEL() and PINMUX_IPSR_MODSEL_DATA()
> are FN_xxx order, and PINMUX_IPSR_MSEL() is used only from r8a7778.
> Now it r8a7778 works correctly with PINMUX_IPSR_MODSEL_DATA() order.
> This means we can merge PINMUX_IPSR_MSEL() and PINMUX_IPSR_MODSEL_DATA().
>
> Current PFC driver is very difficult to read, because macro names are
> using different lenth. Especially PINMUX_IPSR_MODSEL_DATA() is well
> used macro
>
>         PINMUX_IPSR_NOGP(ispr, ...)
>         PINMUX_IPSR_DATA(ipsr, ...)
>         PINMUX_IPSR_NOGM(ispr, ...)
>         PINMUX_IPSR_NOFN(ipsr, ...)
>         PINMUX_IPSR_MSEL(ipsr, ...)
>         PINMUX_IPSR_MODSEL_DATA(ipsr, ...)
>
> It can be readable if we can merge PINMUX_IPSR_MSEL() and PINMUX_IPSR_MODSEL_DATA()
>
>         PINMUX_IPSR_NOGP(ispr, ...)
>         PINMUX_IPSR_DATA(ipsr, ...)
>         PINMUX_IPSR_NOGM(ispr, ...)
>         PINMUX_IPSR_NOFN(ipsr, ...)
>         PINMUX_IPSR_MSEL(ipsr, ...)
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>

Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

for the series, Geert will decide how to merge and send a
pull request for the patches to me.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html