Re: [PATCH] drivers: field for new GPIO driver

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Tue, Sep 22, 2015 at 4:00 AM, yd_tseng <yd_tseng@xxxxxxxxxxxxxx> wrote:

Hi,

> This patch adds a new GPIO driver for AMD Promontory chip.  This GPIO
> controller is enumerated by ACPI and the ACPI compliant hardware ID is
> AMDF030.  And the patch file is also attached.

This isn't really working:
X-Mailer: Microsoft Outlook 14.0

Outlook is mangling the patches, please try to figure out how to send patches
using git send-email at your company, also read:
Documentation/SubmittingPatches
Documentation/email-clients.txt

Before posting.

Then send the patch to me, Alexandre, and the linux-gpio@xxxxxxxxxxxxxxx
mailing list, as indicated in the MAINTAINERS file.

In this case, also include Dmitry Eremin-Solenikov <dbaryshkov@xxxxxxxxx>
as he is the author of a previous AMD GPIO driver. Is this hardware really
different or can the old driver be augmented to handle both?

There are some issues with the driver, such as functions being named
*pinctrl* though it seems to be a clean GPIO driver, so rename these
functions. The rest of the review I save for the next posting.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html