Re: [PATCH 9/9 v2] sh-pfc: r8a7795: add SCIFx support

[Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>]

Hi Magnus

> > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> >
> > This patch adds SCIF0/1/2/3/4/5
> >
> > Original patch was created by Geert,
> > and Kuninori Morimoto updated it
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> > Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > ---
> > v1 -> v2
> >
> >  - Add Laurent Acked-by
> 
> Thanks for your update, Morimoto-san!
> 
> One quick question from my side: Is it intentional that you have the
> "From: Kuninori Morimoto.." line at the top?
> 
> It looks a bit strange to me. Since Geert wrote the patch according to
> your commit message and his Signed-off-by is at the top, shouldn't the
> top line also be "From: Geert Uytterhoeven..."?

1st SCIF support patch included only SCIF2,
and Geert sent updated patch series which included bugfix.
And I merged these patches to this patch.
So, I kept my "From".
but I puted Geert on top of Signed-off-by since
non SCIF2 are came from Geert (= big volume)
I'm not sure how to do in this case ...

Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html