RE: Question about patch "pinctrl: cherryview: Do not mask all interrupts on probe"

["Zheng, Lv" <lv.zheng@xxxxxxxxx>]

Hi,

> From: Chen, Yu C
> Sent: Wednesday, September 02, 2015 4:07 PM
> 
> 
> > From: Mika Westerberg [mailto:mika.westerberg@xxxxxxxxxxxxxxx]
> > Sent: Wednesday, September 02, 2015 3:37 PM
> >
> > On Tue, Sep 01, 2015 at 04:09:12PM -0400, João Paulo Rechi Vita wrote:
> > >
> > > I'm working on a ASUS E202SA laptop, in which the brightness keys
> > > depend on this patch to work. Are any plans to have it integrated, in
> > > the original form or in any other?
> >
> > Adding Yu to the loop.
> >
> > Yu was investigating alternative ways to fix this. Did you come to some
> > conclusion?
> 
> Once I wrote a quirk patch to re-enable gpio irq in Embedded Controller driver, and since
> ec driver is loaded before pinctrl driver , I need to modify the patch to add a delay 'request_irq'
> in ec driver, maybe a workqueue mechanism. Then I switched to some other bugs..
> Yes, I'll continue this work recently, please stay tuned.

EC contains early initialization and late initialization.
During early initialization, IMO, you needn't do anything related to the gpio irq.
The late initialization is invoked in the ACPI driver probe callback.
You can locate gpiolib there before proceeding.
If gpiolib is not found, you can return EPROBE_DEFER in this case.
So what's the problem now?

Thanks and best regards
-Lv

> Thanks
> Best Regards,
> Yu
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html