Re: [PATCH 1/5] gpio: etraxfs: use container_of() to get state container

[Rabin Vincent <rabin@xxxxxx>]

On Thu, Aug 27, 2015 at 04:54:18PM +0200, Linus Walleij wrote:
> The state container of the etraxfs GPIO driver is extracted from
> the gpio_chip exploiting the fact that offsetof() the
> struct gpio_chip inside the struct bgpio_chip are both 0, so
> the container_of() is in practice a noop. However if a member
> is added to struct etraxfs_gpio_chip in front of
> struct bgpio_chip, things will break. Using proper container_of()
> avoids this problem.
> 
> Semantically this is a noop, the compiler will optimize it away,
> but syntactically it makes me happier.
> 
> Cc: Rabin Vincent <rabin@xxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Acked-by: Rabin Vincent <rabin@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html