Hello.
On 08/25/2015 03:30 PM, Geert Uytterhoeven wrote:
Hi (Tovaritsj?) Sergei,
Tovarishch. :-)
Matsuoka-san,
From: Koji Matsuoka <koji.matsuoka.xm@xxxxxxxxxxx>
Add VIN0/1 pin groups to R8A7794 PFC driver.
Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@xxxxxxxxxxx>
[Sergei: rebased, renamed, added changelog.]
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
Thanks for your patch!
--- linux-pinctrl.orig/drivers/pinctrl/sh-pfc/pfc-r8a7794.c
+++ linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7794.c
@@ -2789,6 +2789,167 @@ static const unsigned int usb1_mux[] = {
USB1_OVC_MARK,
};
+union vin_data {
+ unsigned int data24[24];
+ unsigned int data20[20];
+ unsigned int data16[16];
+ unsigned int data12[12];
+ unsigned int data10[10];
+ unsigned int data8[8];
+};
+
+#define VIN_DATA_PIN_GROUP(n, s) \
+ { \
+ .name = #n#s, \
+ .pins = n##_pins.data##s, \
+ .mux = n##_mux.data##s, \
+ .nr_pins = ARRAY_SIZE(n##_pins.data##s), \
+ }
As this is the third occurrence of these 2 definitions, perhaps they
should be moved to sh_pfc.h?
I'll look into this.
+/* - VIN1 ----------------------------------------------------------------- */
+static const unsigned int vin1_g_b_pins[] = {
+ /* G */
+ RCAR_GP_PIN(1, 10), RCAR_GP_PIN(1, 11),
+ RCAR_GP_PIN(1, 12), RCAR_GP_PIN(1, 13),
+};
+static const unsigned int vin1_g_b_mux[] = {
+ /* G */
+ VI1_DATA8_MARK, VI1_DATA9_MARK,
+ VI1_DATA10_MARK, VI1_DATA11_MARK,
+};
This is the green channel, to augment red and blue in vin_data8*?
I have no idea, even after rummaging in the BT.* specs mentioned in the
manuals. ITU-R BT.656 only describes 8- and 10-bit interfaces. Matsuoka-san,
any idea?
If yes, would it make sense to have a separate vin1_data12* section,
combining them?
Most probably.
Gr{oetje,eeting}s,
Geert
MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
