On Mon, Aug 10, 2015 at 11:29:58AM +0200, Linus Walleij wrote: > On Tue, Aug 4, 2015 at 11:23 AM, Markus Pargmann <mpa@xxxxxxxxxxxxxx> wrote: > > > The gpio hogging functions are currently only used for gpio-hogging. But > > these functions are widely generic ones which parse gpio device nodes in > > the DT. > > > > Signed-off-by: Markus Pargmann <mpa@xxxxxxxxxxxxxx> > (...) > > /** > > - * of_get_gpio_hog() - Get a GPIO hog descriptor, names and flags for GPIO API > > + * of_parse_gpio() - Get a GPIO hog descriptor, names and flags for GPIO API > > It's not a good name, too generic. It could easily be assued this is > for something > wider. > > of_parse_own_gpio() or something, indicating that this pertains to the > chip itself and not to outside users, would be better. Yes, changed to of_parse_own_gpio() for next version. Best Regards, Markus -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: Digital signature
