Re: [PATCH] gpio:Fix build warning about void to integer cast in the function mmio_74xx_gpio_probe

[Alexandre Courbot <gnurou@xxxxxxxxx>]

On Thu, Jul 16, 2015 at 9:09 PM, nick <xerofoify@xxxxxxxxx> wrote:
>
>
> On 2015-07-16 08:00 AM, Linus Walleij wrote:
>> On Sat, Jul 4, 2015 at 10:34 PM, Nicholas Krause <xerofoify@xxxxxxxxx> wrote:
>>
>>> This fixes the build warning , warning: cast from pointer to integer
>>> of different size when building this file on a x86 allmodconfig
>>> configuration. In order for me to fix this build warning I changed
>>> the cast in the function mmio_74xx_gpio_probe from casting the
>>> variable data of the stucture pointer of_id to uintptr_t rather
>>> then unsigned when assigning to the variable flag of the structure
>>> pointer priv of the structure type mmio_74xx_gpio_priv.
>>>
>>>
>>> Signed-off-by: Nicholas Krause <xerofoify@xxxxxxxxx>
>>
>> Patch applied with some tweaks to the long subject line.
>>
>> Yours,
>> Linus Walleij
>>
> Sorry about that I kinda suck at commit messages if you would like to some me the edit
> so I can get better at it, that would be helpful.

As explained in Documentation/SubmittingPatches: (probably a good idea
to re-read that document)

"For these reasons, the "summary" must be no more than 70-75
characters, and it must describe both what the patch changes, as well
as why the patch might be necessary.  It is challenging to be both
succinct and descriptive, but that is what a well-written summary
should do."

Your patch subject line should not be longer than 70-75 characters. If
you need to be more extensive, do so in the first paragraph of your
commit log.
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html