Re: [PATCH] GPIO: Fix checkpatch.pl issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 9, 2015 at 4:03 AM, Daniel Lockyer
<thisisdaniellockyer@xxxxxxxxx> wrote:
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index 6bc612b..f2cab60 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -1300,9 +1300,8 @@ static void gpio_chip_set_multiple(struct gpio_chip *chip,
>                                 continue;
>                         }
>                         /* set outputs if the corresponding mask bit is set */
> -                       if (__test_and_clear_bit(i, mask)) {
> -                               chip->set(chip, i, test_bit(i, bits));
> -                       }
> +                       if (__test_and_clear_bit(i, mask))
> +                               chip->set(chip, i, test_bit(i, bits));}

That closing bracket at the end of the line does not look like it
should be here. Does gpiolib even compile after this?
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux