Re: [PATCH 1/7] gpio: omap: fix omap_gpio_free to not clean up irq configuration

[Javier Martinez Canillas <javier@xxxxxxxxxxxx>]

Hello Linus,

On Mon, Jun 1, 2015 at 3:11 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Fri, May 22, 2015 at 4:35 PM, Grygorii Strashko
> <grygorii.strashko@xxxxxxxxxx> wrote:
>
>> This patch fixes following issue:
>> - GPIOn is used as IRQ by some dev, for example PCF8575.INT ->  gpio6.11
>> - PCFx driver knows nothing about type of IRQ line (GPIO or not)
>>   so it doesn't request gpio and just do request_irq()
>> - If gpio6.11 will be exported through the sysfs and then un-xeported
>> then IRQs from PCFx will not be received any more, because
>> IRQ configuration for gpio6.11 will be cleaned up unconditionally
>> in omap_gpio_free.
>>
>> Fix this by removing all GPIO IRQ specific code from omap_gpio_free()
>> and also do GPIO clean up (change direction to 'in' and disable debounce)
>> only if corresponding GPIO is not used as IRQ too.
>> GPIO IRQ will be properly cleaned up by GPIO irqchip code.
>>
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@xxxxxxxxxx>
>
> Can I get an ACK or comment from one of the three (!) maintainers
> on atleast these non-RFC patches?
>

Sorry for the delay, the patch looks good to me.

Acked-by: Javier Martinez Canillas <javier@xxxxxxxxxxxx>

> Yours,
> Linus Walleij

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html