Re: [PATCH] gpio: Prevent an integer overflow in the pca953x driver

[Alexandre Courbot <gnurou@xxxxxxxxx>]

On Fri, May 22, 2015 at 9:35 AM, Joshua Scott
<joshua.scott@xxxxxxxxxxxxxxxxxxx> wrote:
> Interrupts were missed if an 8-bit integer overflow occurred. This was
> observed when bank0,pin7 and bank1,pin7 changed simultaniously.
>
> As the 8-bit totals were only checked against zero, replace them with
> booleans. Name the booleans so that their purpose is clear.
>
> Signed-off-by: Joshua Scott <joshua.scott@xxxxxxxxxxxxxxxxxxx>

Looks good, I wonder why += was used instead of |= ? Or why a bool was
not used in the first place since per-pin information is never used
anyway.

Reviewed-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html