Re: [PATCH 3/3] pinctrl: tegra-xusb: Check that of_match_node returns a valid pointer

[Jon Hunter <jonathanh@xxxxxxxxxx>]

On 19/05/15 15:18, Thierry Reding wrote:
> * PGP Signed by an unknown key
> 
> On Tue, May 19, 2015 at 03:14:23PM +0100, Jon Hunter wrote:
>> of_match_node() will return NULL if no match is found and so check for
>> this before dereferencing the pointer.
>>
>> Signed-off-by: Jon Hunter <jonathanh@xxxxxxxxxx>
>> ---
>>  drivers/pinctrl/pinctrl-tegra-xusb.c | 3 +++
>>  1 file changed, 3 insertions(+)
> 
> This isn't necessary. The driver is probed from DT only and therefore
> .probe() will only be called if there's a matching entry in the OF
> device ID table. match can never be NULL.

Ah, ok that would make sense.

Cheers Jon
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html