Re: [PATCH 1/2] gpio: max732x: Propagate wake-up setting to parent irq controller

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Mon, May 4, 2015 at 8:23 PM, Sam Protsenko
<semen.protsenko@xxxxxxxxxxxxxxx> wrote:
> On Mon, May 4, 2015 at 4:32 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:

>> Patch applied, but it seems we need a general approach to
>> cover a few GPIO drivers with this kind of thing.
>>
>> Is this how we should always do it?
>
> I think so (well, at least it seems to be correct for GPIO expanders). But I'd
> verify each particular driver to be completely sure that it's really needed and
> it wouldn't create some new issues. MAX732X chip seems to be very similar to
> PCF857X one, so in this particular case I'm sure that this patch is a good thing
> to have.

OK yeah, maybe we could provide a list of "usual suspects", what do you
say about "my" expanders:

drivers/gpio/gpio-stmpe.c
drivers/gpio/gpio-tc3589x.c

I can surely patch and test these.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html