Re: [PATCH 2/4] gpio: gpio-generic: add flag to read out output value from reg_set

[Vladimir Zapolskiy <vladimir_zapolskiy@xxxxxxxxxx>]

On 11.05.2015 12:50, Linus Walleij wrote:
> On Wed, Apr 29, 2015 at 5:34 PM, Vladimir Zapolskiy
> <vladimir_zapolskiy@xxxxxxxxxx> wrote:
> 
>> The change introduces BGPIOF_READ_OUTPUT_REG_SET flag for gpio-generic
>> GPIO chip implementation, which allows to get correct configured value
>> from reg_set register, input value is still get from reg_dat.
>>
>> Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@xxxxxxxxxx>
> 
> Looks reasonable. Patch applied.
> 
> Do we need device tree bindings for this?

I don't think so, particular drivers have this as a fixed property, and
"basic-mmio-gpio" has no device tree bindings.

OTOH let see on dynamics of the flag usage, if it grows, it may happen
that its negation is a better candidate for a quirk.

--
With best wishes,
Vladimir

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html