Re: [PATCH v3 1/1] pinctrl: at91: Add set_multiple GPIO chip feature

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Thu, Apr 2, 2015 at 11:55 AM, Alexander Stein <alexanders83@xxxxxx> wrote:

> This adds the callback for set_multiple.
> As this controller has a separate set and clear register, we can't write
> directly to PIO_ODSR as this would required a cached variable and would
> race with at91_gpio_set.
> So build masks for the PIO_SODR and PIO_CODR registers and write them
> together.
>
> Signed-off-by: Alexander Stein <alexanders83@xxxxxx>
> ---
> I Just realized that some implementations have less than 32 pins. Thus
> BITS_MASK(chip->ngpio) as suggested by Jean-Christophe is actually required.
> I missed that, sorry for the noise.
>
> Changes in v3:
> * As not all GPIO controllers have 32 pins take ngpio into account
>   Mask the set- and clear-mask to the supported GPIO pins

No more comments on v3 so patch applied for v4.2.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html