On Tue, Apr 21, 2015 at 09:08:53AM -0700, Tony Lindgren wrote: > Looks like omap_gpio_irq_type can return early at several places > leaving a GPIO bank enabled without doing pm_runtime_put if wrong > GPIO arguments are passed. > > Instead of adding more complicated BANK_USED macros, let's fix the > issue properly. We can pass is_irq flag to omap_enable_gpio_module > and omap_disble_gpio_module. And with that we can remove all the > similar code elsewhere to get rid of most BANK_USED macros. > > Note that the reason for the BANK_USED macro is that we need to manage > PM runtime on per GPIO bank basis. In the long run we want to move to > using PM runtime counts for each GPIO line to determine if a GPIO > bank is used. Once we have a solution for omap_enable_gpio_module > and omap_disable_gpio_module, we can remove the remaining BANK_USED > macros. > > Cc: Felipe Balbi <balbi@xxxxxx> > Cc: Grygorii Strashko <grygorii.strashko@xxxxxxxxxx> > Cc: Javier Martinez Canillas <jmartinez@xxxxxxxxxxxxxx> > Cc: Nishanth Menon <nm@xxxxxx> > Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx> looks ok to my eyes. Reviewed-by: Felipe Balbi <balbi@xxxxxx> -- balbi
Attachment:
signature.asc
Description: Digital signature
