Re: [PATCH v4 07/11] ARM: imx: add msl support for imx7d

[Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx>]

This looks a lot better, thanks - just one remaining comment:

On Tue, Apr 21, 2015 at 05:05:29AM +0800, Frank.Li@xxxxxxxxxxxxx wrote:
> +static void __init imx7d_map_io(void)
> +{
> +	debug_ll_io_init();
> +}

If that's all that you need here, please get rid of it; the generic code
will make that call for you if you don't provide a .map_io method below:

> +DT_MACHINE_START(IMX7D, "Freescale i.MX7 Dual (Device Tree)")
> +	.map_io		= imx7d_map_io,
> +	.smp            = smp_ops(imx_ca7_smp_ops),
> +	.init_irq	= imx7d_init_irq,
> +	.init_machine	= imx7d_init_machine,
> +	.dt_compat	= imx7d_dt_compat,
> +	.restart	= mxc_restart,
> +MACHINE_END

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html