Re: [PATCH v5 10/15] serial: stm32-usart: Add STM32 USART Driver

[Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>]

2015-04-03 19:43 GMT+02:00 Joe Perches <joe@xxxxxxxxxxx>:
> On Fri, 2015-04-03 at 19:01 +0200, Maxime Coquelin wrote:
>> This drivers adds support to the STM32 USART controller, which is a
>> standard serial driver.
>
> trivia:
>
>> diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c
> []
>> +static struct uart_ops stm32_uart_ops = {
>
> could be const

i would even say, should be const.

>
> and it could be updated in a separate patch later too.
>

Nope, I will send another version anyway, so it will be part of the v6.

Thanks for the review,
Maxime
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html