Re: [PATCH v5 07/15] dt-bindings: Document the STM32 timer bindings

[Rob Herring <robherring2@xxxxxxxxx>]

On Fri, Apr 3, 2015 at 12:01 PM, Maxime Coquelin
<mcoquelin.stm32@xxxxxxxxx> wrote:
> This adds documentation of device tree bindings for the
> STM32 timer.
>
> Tested-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>

One minor thing below, otherwise:

Acked-by: Rob Herring <robh@xxxxxxxxxx>

> ---
>  .../devicetree/bindings/timer/st,stm32-timer.txt   | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/timer/st,stm32-timer.txt
>
> diff --git a/Documentation/devicetree/bindings/timer/st,stm32-timer.txt b/Documentation/devicetree/bindings/timer/st,stm32-timer.txt
> new file mode 100644
> index 0000000..d3fdeb0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/timer/st,stm32-timer.txt
> @@ -0,0 +1,22 @@
> +. STMicroelectronics STM32 timer
> +
> +The STM32 MCUs family has several general-purpose 16 and 32 bits timers.
> +
> +Required properties:
> +- compatible : Should be st,stm32-timer"

Missing quote

> +- reg : Address and length of the register set
> +- clocks : Reference on the timer input clock
> +- interrupts : Reference to the timer interrupt
> +
> +Optional properties:
> +- resets: Reference to a reset controller asserting the timer
> +
> +Example:
> +
> +timer5: timer@40000c00 {
> +       compatible = "st,stm32-timer";
> +       reg = <0x40000c00 0x400>;
> +       interrupts = <50>;
> +       resets = <&rrc 259>;
> +       clocks = <&clk_pmtr1>;
> +};
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html