Re: [PATCH 1/2] pinctrl: at91: Add set_multiple GPIO chip feature

[Jean-Christophe PLAGNIOL-VILLARD <plagnioj@xxxxxxxxxxxx>]

J
> On Mar 27, 2015, at 5:07 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> 
> On Fri, Mar 20, 2015 at 8:12 PM, Alexander Stein <alexanders83@xxxxxx> wrote:
> 
>> This adds the callback for set_multiple.
>> As this controller has a separate set and clear register, we can't write
>> directly to PIO_ODSR as this would required a cached variable and would
>> race with at91_gpio_set.
>> So build masks for the PIO_SODR and PIO_CODR registers and write them
>> together.
>> 
>> Signed-off-by: Alexander Stein <alexanders83@xxxxxx>
>> ---
>> This was tested by using an own test driver which uses
>> gpiod_set_array_cansleep to set multiple GPIOs at once.
> 
> I remember J-C brought this up ages ago, so I hope he will be delighted
> to see we can now, FINALLY, do this!
> 
> J-C can I have your review on this?

I will check it tonight

Best Regards,
J.
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html