Re: [PATCH] pinctrl: mvebu: add suspend/resume support to Armada XP pinctrl driver

[Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx>]

Linus,

On Fri, 27 Mar 2015 09:37:19 +0100, Linus Walleij wrote:

> Patch applied, but:
> 
> >  static void __iomem *mpp_base;
> > +static u32 *mpp_saved_regs;
> 
> I didn't notice this singleton design pattern in this driver before :(
> I see the legacy Dove driver have a few more.
> 
> Can we have a mvebu refactoring patch bringing these things into a state
> container? Like a per-subdriver kmalloc:ed struct foo_state {}?

Yes, I agree this isn't nice. I'll try to nice what I can come up with
and propose a patch.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html