Re: [PATCH v6 6/8] pinctrl: cygnus: add gpio/pinconf driver

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Wed, Mar 11, 2015 at 10:15 AM, Linus Walleij
<linus.walleij@xxxxxxxxxx> wrote:
> On Tue, Mar 10, 2015 at 6:57 PM, Ray Jui <rjui@xxxxxxxxxxxx> wrote:
>> On 3/10/2015 3:20 AM, Linus Walleij wrote:
>>> On Mon, Mar 9, 2015 at 9:45 PM, Ray Jui <rjui@xxxxxxxxxxxx> wrote:
>>>
>>>> This adds the initial support of the Broadcom Cygnus GPIO/PINCONF driver
>>>> that supports all 3 GPIO controllers on Cygnus including the ASIU GPIO
>>>> controller, the chipCommonG GPIO controller, and the always-on GPIO
>>>> controller. Basic PINCONF configurations such as bias pull up/down, and
>>>> drive strength are also supported in this driver.
>>>>
>>>> Pins from the ASIU GPIO controller can be individually muxed to GPIO
>>>> function, through interaction with the Cygnus IOMUX controller
>>>>
>>>> Signed-off-by: Ray Jui <rjui@xxxxxxxxxxxx>
>>>> Reviewed-by: Scott Branden <sbranden@xxxxxxxxxxxx>
>>>> Tested-by: Dmitry Torokhov <dtor@xxxxxxxxxxxx>
>>>
>>> Patch applied! But please look at this:
>>>
>>>> +#include <linux/gpio.h>
>>>
>>> Doesn't just #include <linux/gpio/driver.h> work?
>>>
>>
>> I think I need linux/gpio.h for gpiochip_add_pin_range and some related
>> APIs.
>
> OK you're right ... I need to fix this.

I sent a patch fixing this now... hope it will work.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html