Re: [PATCH] pinctrl: Add initial driver data for Alphascale asm9260

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

Hi Oleksij,

Thanks for your patch.

On Thu, Feb 12, 2015 at 12:32 PM, Oleksij Rempel <linux@xxxxxxxxxxxxxxxx> wrote:

Also send the patch to linux-kernel@xxxxxxxxxxxxxxx as that is the
default pin control mailing list.

Split off Device Tree bindings in its own file and send that also to
devicetree@xxxxxxxxxxxxxxx for review.

> This patch adds initial driver data for Alphascale asm9260 pinctrl support.
>
> Signed-off-by: Oleksij Rempel <linux@xxxxxxxxxxxxxxxx>

A bit terse description, tell us a bit more about the system in the initial
commit, and what silicon it lives in etc.

> +The pinctrl driver enables Alphascale ASM9260 to configure the multi-purpose pins
> +(MPP) to a specific function.

MPP? That is a new name again for pin multiplexing, alternate function,
mission mode etc... apparently people have a problem with what to
call this.

(...)
> +Please refer to pinctrl-bindings.txt in this directory for details of the
> +common pinctrl bindings used by client devices, including the meaning of the
> +phrase "pin configuration node".

Nice. Good that you use generic bindings.

> +The following generic properties as defined in pinctrl-bindings.txt are valid
> +to specify in a pin configuration subnode:
> +pins                   - the list of pins that properties in the node
> +                         apply to (either this or "group" has to be
> +                         specified)

Should be "groups" not "group". Several groups can map to one
function.

> +function               - the mux function to select
> +bias-disable           - disable any pin bias
> +bias-pull-up           - pull up the pin. Supported only on GPIO0_* pins.
> +bias-pull-down         - pull down the pin. Supported on all pins except of GPIO0_*.

Nice, good details.

(...)
> +struct asm9260_function {
> +       const char              *name;
> +       const char              **groups;
> +       unsigned int            ngroups;
> +};

Yes, see one function, many groups.

The driver looks simple and nice.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html