Re: [PATCH] pinctrl: at91: move lock/unlock_as_irq calls into request/release resources methods

[Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>]

On Fri, 20 Feb 2015 15:50:36 +0800
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@xxxxxxxxxxxx> wrote:

> 
> > On Feb 9, 2015, at 10:50 PM, Jean-Christophe PLAGNIOL-VILLARD <plagnioj@xxxxxxxxxxxx> wrote:
> > 
> > 
> >> On Feb 9, 2015, at 2:23 AM, Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx> wrote:
> >> 
> >> The gpiochip_lock_as_irq call can fail and return an error, while the
> >> irq_startup is not expected to fail (returns an unsigned int which is not
> >> checked by irq core code).
> >> 
> >> irq_request/release_resources functions have been created to address this
> >> problem.
> >> 
> >> Move gpiochip_lock/unlock_as_irq calls into
> >> irq_request/release_resources functions to prevent using a gpio as an irq
> >> if the gpiochip_lock_as_irq call failed.
> >> 
> >> Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>
> >> —
> > 
> > I’m travelling will take a look end of the week
> 
> just get back from travelling will take a look after Chinese new year
> as all my hw are at the office

Ping



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html