Re: [PATCH 0/2] gpio: pcf857x: Use gpiolib irqchip helpers and fix wake-up

[Alexandre Courbot <gnurou@xxxxxxxxx>]

On Tue, Feb 24, 2015 at 7:41 PM, Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
> On Thu, Feb 5, 2015 at 4:49 PM, Geert Uytterhoeven
> <geert+renesas@xxxxxxxxx> wrote:
>> This patch series switches the PCF857x GPIO driver to use the gpiolib
>> irqchip helpers, as requested by Linus Walleij, and fixes wake-up by
>> propagating the wake-up setting to the parent irq controller.
>>
>> Note that the conversion to gpiolib irqchip helpers removes the checks
>> added in commit 21fd3cd1874a2ac8 ("gpio: pcf857x: call the gpio user
>> handler iff gpio_to_irq is done"), as the interrupt mappings are no
>> longer created on-demand by the driver, but by gpiochip_irqchip_add()
>> during initialization.  I marked the first patch "RFC" because of
>> this.  Does the removal of the checks cause problems for anyone?
>>
>> The second patch was sent before, and rebased on top of the
>> conversion to gpiolib irqchip helpers.
>>
>> This was tested on sh73a0/kzm9g, where I don't see the issue addressed
>> by commit 21fd3cd1874a2ac8 ("gpio: pcf857x: call the gpio user handler
>> iff gpio_to_irq is done").
>>
>> Thanks for your comments!
>
> No comments?

Apologies - I'd like to review this but am not familar enough with the
IRQ helpers. Linus seems to be busy, hopefully he will find time to
check this out...
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html