Re: [PATCH v2 2/4] gpio: add parameter to allow the use named gpios

[Bryan Wu <cooloney@xxxxxxxxx>]

On Fri, Jan 30, 2015 at 5:46 AM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Wed, Jan 21, 2015 at 10:33 PM, Olliver Schinagl
> <o.schinagl@xxxxxxxxxxxxx> wrote:
>
>> From: Olliver Schinagl <oliver@xxxxxxxxxxx>
>>
>> The gpio binding document says that new code should always use named
>> gpios. Patch 40b73183 added support to parse a list of gpios from child
>> nodes, but does not make it possible to use named gpios. This patch adds
>> the con_id property and implements it is done in gpiolib.c, where the
>> old-style of using unnamed gpios still works.
>>
>> Signed-off-by: Olliver Schinagl <oliver@xxxxxxxxxxx>
>> ---
>>  drivers/gpio/devres.c                     | 18 +++++++++++++++++-
>>  drivers/input/keyboard/gpio_keys_polled.c |  2 +-
>>  drivers/leds/leds-gpio.c                  |  2 +-
>>  include/linux/gpio/consumer.h             |  1 +
>
> Alexandre: does this match your vision of how it should work, i.e. ACK?
>
> Bryan/Dmitry: can you ACK the oneliners in your subsystems?

Sure, please take my Ack
Acked-by: Bryan Wu <cooloney@xxxxxxxxx>

>
> Yours,
> Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html